Maxime Coste
42d7b66b92
Support hitting escape to cancel a selection combine operation
...
Fixes #1443
2017-06-16 10:23:03 +01:00
Maxime Coste
42f03fb71f
Hide info/menu when they are anchored to an invisible buffer coord
...
Fixes #1444
2017-06-16 10:19:08 +01:00
Maxime Coste
2992d5bb0b
Fix some remaining uses of invalid atom coordinates
2017-06-16 08:06:24 +01:00
Maxime Coste
4ed790632d
Fix some other uses of invalid buffer coordinates in display code
2017-06-15 18:12:21 +01:00
Maxime Coste
fa4b88c2f8
Move tolerance for one past end of line coordinates to highlighter code
...
The rest of Kakoune's code now requires coord passed to Buffer::iterator_at
to be valid.
2017-06-15 17:43:18 +01:00
Maxime Coste
01a1e92b79
Fix crash recently introduced when deleting at buffer start in insert mode
2017-06-15 17:35:48 +01:00
Maxime Coste
e6c4bed42b
Go back to window lines ending at one past the end of the buffer line
...
Change Buffer::iterator_at so that this case is tolerated, and fixes
the coord to next line start instead of clamping to last line char.
2017-06-15 17:25:37 +01:00
Maxime Coste
724b4198b0
Change window display to not use invalid buffer coordinates
...
Fixes #1435
2017-06-15 16:48:16 +01:00
Maxime Coste
40f845d77e
Respect scroll offset even when wrapping lines
...
Fixes #1433 although in a slightly different way than requested:
We ensure that scrolloff *displayed* lines are visible below the
cursor, not scrolloff *buffer* lines.
2017-06-15 12:29:34 +01:00
Maxime Coste
98627726cf
Always store InclusiveBufferRange with first < second
...
Closes #1434
2017-06-13 09:00:55 +01:00
Maxime Coste
ab56be090a
minor style tweak
2017-06-12 06:12:10 +01:00
Maxime Coste
208b28cbe7
Simplify a bit buffer iteration functions
...
Dont try to ensure the returned value is valid, incrementing past
the end/decrementing before begin is the caller's error.
2017-06-12 06:10:18 +01:00
Maxime Coste
250886a9e1
Use read_fd to get pipe command from stdin instead of ad-hoc code
...
read_fd will also now throw on read error instead of just returning
the data read so far as if nothing failed.
2017-06-12 05:21:34 +01:00
Maxime Coste
7bcfbd055c
Fix corner case in compute_modified_ranges
2017-06-11 12:25:12 +01:00
Maxime Coste
63a791d651
Fix the Buffer::end() madness
...
Until now, buffer had multiple recognized end coordinates, either
{ line_count, 0 } or { line_count - 1, line[line_count - 1].length }.
Now the only correct end coord is { line_count, 0 }, removing the need
for various special cases.
2017-06-11 12:01:40 +01:00
Maxime Coste
d86a612774
Fix wrapping support
2017-06-09 16:00:22 +01:00
Maxime Coste
0dec1e3a91
Remove unused only_buffer mode for DisplayLine::trim
2017-06-09 15:30:13 +01:00
Maxime Coste
7b9d8d39b1
Simplify column highlighter and make it more robust
...
Fixes #1382
2017-06-09 15:24:07 +01:00
Maxime Coste
3612eb50e5
Fix bug in word completer
...
A bug could be triggered in the word completer when a multiselection
would trigger word completion with one selection being at buffer first
character.
2017-06-09 14:21:18 +01:00
Maxime Coste
64aa6f3fb4
Proper linear time insert completion insertion
...
The previous solution, ad9b090ddf
, was
failing when completion was not replacing any text, as going through
SelectionList was not permitting to replace empty ranges.
Handle replacement as first a deletion then an insert to get fast
update, as having a list of forward deletions and then a list
for forwad insertion is much faster to update than a list of
interleaved delete/insert.
2017-06-09 14:13:43 +01:00
Maxime Coste
f310db639c
Rework partial line display logic
...
Instead of highlighting full lines and then trim them to make them
fit in the window, highlight only the visible portion, and rely on
the compute_display_setup system introduced for wrapping to setup
our buffer range correctly
2017-06-09 13:22:32 +01:00
Maxime Coste
242f951c84
More explicit and simpler code
2017-06-09 09:54:18 +01:00
Maxime Coste
fe46c05685
Remove spurious double underscore
2017-06-08 10:37:48 +01:00
Maxime Coste
2b5fafa909
Do not show startup info when piping into kak
...
Fixes #1340
2017-06-08 10:03:07 +01:00
Maxime Coste
ad9b090ddf
Fix quadratic behaviour in when selecting an insert completion
...
Use the fast, linear time SelectionList::insert algorithm instead of
an ad-hoc one that needs to call SelectionList::update after each
modification of the buffer.
Fixes #1417
2017-06-08 09:55:34 +01:00
Maxime Coste
4ab40af3a9
Disable idle timers on all transient contexts
2017-06-08 09:53:23 +01:00
Maxime Coste
609b0bbbac
Merge remote-tracking branch 'Delapouite/rotate-forward'
2017-06-08 07:14:20 +01:00
Maxime Coste
eadf8930fb
Add -width <max_width>
support in the wrap highlighter
...
Will always wrap at the minimum between max_width and actual window
width.
Fixes #1424
2017-06-08 07:05:44 +01:00
Maxime Coste
acc2dbf79c
Move variable closer to its point of use
2017-06-07 20:33:34 +01:00
Maxime Coste
56b52bdb3d
Filter debug buffers before creating the SafePtr vector in -buffer *
2017-06-07 20:25:39 +01:00
Maxime Coste
e947c20ce0
Do not disable incsearch option in context wrap
...
It will only trigger on idle, which should not happen during non-
interactive contexts.
2017-06-07 20:24:37 +01:00
Maxime Coste
03f8679e5c
Only trigger PromptEvent::Change on idle
...
There is no need to trigger that event on every keystroke, we can
trigger it only when we hit the idle timeout, avoiding computations
when input keys are pasted.
2017-06-07 20:16:19 +01:00
Maxime Coste
b81500c0e4
Use microseconds instead of milliseconds for built-in profiling
2017-06-07 20:06:47 +01:00
Maxime Coste
1c0bdd8c85
Run BufCreate hook *before* Buf{Open,New}File
2017-06-07 19:46:43 +01:00
Maxime Coste
4495aefea6
Use range based find_if wrapper for finding shell env vars
2017-06-07 19:46:16 +01:00
Maxime Coste
d9b1ee13d9
Change merge_overlapping to guarantee we dont break the sorting
...
In certain cases, we could end up with a unsorted selection list,
leading to broken invariant.
2017-06-07 19:30:44 +01:00
Maxime Coste
1d4093bcdc
Fix memory errors due to sharing the MatchResults in the Hooks struct
...
A hook execution triggered by another hook execution would change the
shared MatchResults object, which is a wrong behaviour and makes it
point to dead string data.
2017-06-07 19:18:15 +01:00
Maxime Coste
575e6fe325
Remove unneeded unknown_expand exception type
2017-06-07 19:01:26 +01:00
Maxime Coste
b7982c6ee3
Use range based accumulate wrapper instead of std::accumulate
2017-06-07 13:36:47 +01:00
Maxime Coste
a0d848da8d
Do not allow whitespaces as % string delimiters
2017-06-07 13:09:45 +01:00
Maxime Coste
f0285a8e60
Move hook executing logic into HookManager
...
The existing HookManager was able to run arbitrary hook functions,
but in practice was only used for user provided textual hooks.
That separation was causing some suboptimal performances, by moving
that logic directly in the hook manager we can improve hook filtering
performance which is a big part of startup time when opening lots
of files.
2017-06-07 12:33:39 +01:00
Maxime Coste
4606453fed
Avoid expensive copies of Hooks in HookManager::run_hooks
...
Use a deferred deletion mechanism to ensure hooks are kept alive
for the duration of run_hooks.
2017-06-07 12:15:16 +01:00
Maxime Coste
87477cf2bb
Move NestedBool to utils.hh
2017-06-07 11:55:42 +01:00
Maxime Coste
21da24235a
Small style tweak
2017-06-07 11:40:13 +01:00
Maxime Coste
5a5d2ad7cb
noexcept-ify utf8::iterator methods
2017-06-07 10:58:49 +01:00
Maxime Coste
cb6ef4afb6
noexept-ify BufferIterator methods
2017-06-07 10:58:01 +01:00
Maxime Coste
502c5da0e9
Fix useles copy of hook_func in HookManager::add_hook parameter
2017-06-07 09:54:58 +01:00
Maxime Coste
295fa5b27d
Use String default ctor instead of empty string
2017-06-07 09:54:11 +01:00
Maxime Coste
a5e7b6a22f
Use a vector instead of a hash map to store hooks
2017-06-07 09:46:05 +01:00
Delapouite
86cc66577b
Clarify rotation direction between <'> and <a-'> in info help
2017-06-07 08:53:33 +02:00
Maxime Coste
fd00e1f9ae
Merge remote-tracking branch 'Delapouite/underscore'
2017-06-07 07:48:57 +01:00
Maxime Coste
d214969d5b
Merge remote-tracking branch 'Delapouite/buf_line_count'
2017-06-07 07:48:32 +01:00
Maxime Coste
9cb9e77dc2
Merge remote-tracking branch 'Delapouite/view-count'
2017-06-07 07:45:53 +01:00
Delapouite
09daaa8b3a
Expose kak_buf_line_count
2017-06-06 14:29:06 +02:00
Delapouite
2f84051efb
Add underscore char as a valid punctuation for text-object pairs
2017-06-06 12:04:53 +02:00
Delapouite
b4af4994fb
Remember previous NormalParams::count in view-lock mode
2017-06-06 09:52:02 +02:00
Maxime Coste
36364d5f6b
Fix spurious copies being made when using the format function
...
We were not correctly forwarding the arguments, leading to copies of
'const String&' parameters.
2017-06-06 08:50:51 +01:00
Maxime Coste
73ecbdbc97
Log errors written to the status line inside the debug buffer as well
...
Fixes #1410
2017-06-04 08:48:23 +01:00
Maxime Coste
261e0fabcc
Improve readability of command docstrings by changing formatting
...
Fixes #1378
2017-06-04 08:37:51 +01:00
Maxime Coste
6101138606
Change RankedMatch ordering to favor /
characters
...
This will improve matching of filenames, as 'foo/' will be sorted
before 'foo-bar' due to `/` coming before `-` in the new ordering
(it comes after in ascii/unicode order).
Fixes #1395
2017-06-04 08:27:53 +01:00
Maxime Coste
96813ee824
Document the *
behaviour change in the startup message
2017-06-03 18:17:44 +01:00
Maxime Coste
c1e4b4ff79
Strip surrounding whitespaces in *
...
Fixes #1406
2017-06-03 18:16:40 +01:00
Maxime Coste
8dc9f8cc22
Support option_add for HashMap options
...
Fixes #1407
2017-06-03 18:01:38 +01:00
Maxime Coste
6906e6924b
Merge remote-tracking branch 'occivink/ignore-debug'
2017-06-03 15:26:51 +01:00
Maxime Coste
a313dab90f
Merge remote-tracking branch 'Delapouite/include'
2017-06-03 14:46:03 +01:00
Maxime Coste
c440bbde81
Merge remote-tracking branch 'Delapouite/shift-modes'
2017-06-03 14:45:48 +01:00
Maxime Coste
58dfd76dca
Small formatting fix
2017-06-03 14:02:43 +01:00
Maxime Coste
0e88a9695a
Add support for more selection combining operations
...
Change append to 'a', add select longest/shortest, union and
intersection.
2017-06-03 13:45:59 +01:00
Delapouite
e8707298c1
Refine info titles to distinguish G and V modes
2017-05-31 19:57:56 +02:00
Delapouite
ccecc2b7cf
fix: remove duplicate include to containers.hh in face_registry.cc
2017-05-30 20:01:31 +02:00
Maxime Coste
f6e00ff00f
Merge remote-tracking branch 'Delapouite/typo'
2017-05-29 10:20:21 +01:00
Maxime Coste
b030088d60
Re-hide hardware cursor, seems its causing troubles with various terminal emulator
2017-05-29 10:02:18 +01:00
Maxime Coste
62def0f4df
Tweak alias command docstring not to end up with an eol
2017-05-28 19:58:24 +01:00
Maxime Coste
76d3425bf9
Change ncurses_ui info box generation logic to use a Vector<String>
...
We were generating a string, then splitting it into lines, there is
no need for that, we can directly generate a vector of lines and
simplify the code.
2017-05-28 19:58:18 +01:00
Olivier Perret
9697f61b0d
Exclude debug from eval/exec over all buffers
2017-05-27 23:44:53 +02:00
Delapouite
c9c868d4de
Fix typos in info-box: availabe, encodngs, highglighters…
2017-05-27 22:37:25 +02:00
Maxime Coste
e97f23f2be
Use more precise wording for object selection info box
2017-05-27 09:29:51 +01:00
Maxime Coste
bc92633ddd
Put the doc/manpages/ pages in the 'k' section
2017-05-27 07:35:13 +01:00
Maxime Coste
72acb0177d
Parse meta as 8 bit in Normal mode to fix the terminals using that
...
The solution is a bit hackish, as we only consider the 8th bit to
mean alt in normal mode, because its unlikely accentuated characters
are going to be mapped there. It fixes using Alt on xterm, and
probably on iterm2 as well (not requiring the meta-sends-esc config
change anymore)
2017-05-27 06:18:39 +01:00
Maxime Coste
b9080d8b2c
Document line-flags -> line-specs and update-option in breaking changes
2017-05-27 06:18:02 +01:00
Maxime Coste
f57e72ab4a
Small code tweak
2017-05-27 06:17:44 +01:00
Maxime Coste
f2c0ee62ce
Remove unneeded explicit conversion
2017-05-26 09:51:32 +01:00
Maxime Coste
57ef592f57
Remove unused and potentially error prone constructor from ArrayView
...
Add as well a SFINAE check to the vector constructor to avoid constructing
an array_view from derived types with a different size.
2017-05-26 09:25:25 +01:00
Maxime Coste
2307cf500c
Small formatting tweak
2017-05-26 08:38:12 +01:00
Maxime Coste
11f924c528
Use a ScopedSetBool instead of manual set/unset for InputModes::Normal::m_in_on_key
2017-05-26 08:28:34 +01:00
Maxime Coste
5a93159012
Small code style tweak
2017-05-26 08:19:35 +01:00
Maxime Coste
b1bb9d0cb2
Small documentation tweak in display_buffer.hh
2017-05-26 08:00:15 +01:00
Maxime Coste
6e389512f5
Modernize the way we compute memory domains from type
...
Use a constexpr function instead of a template type
2017-05-26 07:59:18 +01:00
Dan Rosén
b1735ae76e
Expose last entered command in register :
2017-05-25 21:48:41 +02:00
Maxime Coste
83d85df26e
Add an update-option command to update range-descs/line-descs options
...
update-option will make the range-descs and line-descs option up to
date with the latest buffer modfications, changing the ranges/lines
to where they moved according the modifications since the timestamp
on the option.
2017-05-25 19:54:08 +01:00
Maxime Coste
f014eb7052
Fix command parsing bug when commenting after a command
...
When a comment was present directly on the same line after a command,
we did not correctly see the command as terminated and would join
continue parsing the next line.
2017-05-25 08:30:49 +01:00
Maxime Coste
c4db46b58b
Rename line-flags option type to line-specs
...
Generalize this option type, which is a timestamped list of
<line number>|<arbitrary string>. That way this type is not strongly
coupled with the flag-lines highlighter, and can be reused for other
use cases.
2017-05-24 15:41:43 +01:00
Maxime Coste
074666d298
Small code tweak
2017-05-24 15:40:16 +01:00
Maxime Coste
119a5b8442
Fix hardware cursor positioning in prompt when status bar is on bottom
2017-05-24 15:20:23 +01:00
Maxime Coste
720e567ac2
Remove unneeded forward declaration
2017-05-23 19:11:13 +01:00
Maxime Coste
7ee3039a79
Do not avoid eol in insert mode vertical movement
2017-05-22 17:04:01 +01:00
Maxime Coste
28bcb45b92
Fix bug where idle timers of disabled modes were still run
2017-05-22 16:57:22 +01:00
Maxime Coste
bc11e52960
Remove virtual destructor from OptionManagerWatcher
...
We should never destruct anything through an OptionManagerWatcher
pointer, so having all those destructor virtual makes no sense.
2017-05-22 10:31:56 +01:00
Maxime Coste
bdcfe30834
Fix scrolling when cursor is on a wrapped part of the last displayed line
2017-05-22 08:54:25 +01:00
Maxime Coste
ad9ad7e603
Fix vertical movement with tabstops
...
Fixes #1388
2017-05-21 08:24:44 +01:00