xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
6,921 Commits 1 Branch 0 Tags 17 MiB
ed84a2d60c
Commit Graph

157 Commits

Author SHA1 Message Date
Maxime Coste
14f9f4c468 Fix use after delete in RemoteClient FDWatcher callback 
Fixes #2357
 2018-09-07 09:09:07 +10:00
Matt Peterson
d0a8426272 Use $USER if getpwuid fails 2018-08-24 10:50:59 -04:00
Maxime Coste
4ef5c80724 Fix Kakoune client busy looping on SIGHUP 
Pure clients never quitted when they got SIGHUP after recent changes
to add is_ok to UserInterface. run_client now tracks the UI state as
well and quits if the UI gets killed.
 2018-05-23 08:16:35 +10:00
Maxime Coste
79b60f69a9 Small code cleanups 2018-05-17 22:55:53 +10:00
Maxime Coste
7a841dcca7 Remove out of date noexcept(false) on MessageWriter destructor 
This made sense when the writer was trying to send the message
in its destructor, but this is not the case anymore.
 2018-05-05 07:59:13 +10:00
Maxime Coste
178d2d3cd3 Rework the way UI can trigger a client quitting 
Add a UserInterface::is_ok method and return false on
SIGHUP/stdin closing/socket dropping

This should be cleaner and more robust than the previous SIGHUP
handling code.

Fixes #1594
 2018-04-29 22:31:57 +10:00
Maxime Coste
2fa553e728 Remove implicit conversion from String to DisplayAtom/DisplayLine 2018-04-29 20:45:53 +10:00
Maxime Coste
6f58c278bf Merge remote-tracking branch 'Delapouite/no-such' 2018-04-07 12:33:15 +10:00
Maxime Coste
23853f499e Add some safety static_asserts to remote read/write functions 2018-04-07 12:32:31 +10:00
Delapouite
cb02186c77 Make error messages more consistent 2018-04-06 16:56:53 +02:00
Maxime Coste
71a1893a5e Fix some trailing spaces and a tab that sneaked into the code base 2018-04-05 08:52:33 +10:00
Maxime Coste
435b5b7ff9 Unify code that validates identifiers in Kakoune 
Session/Client/User modes names are now requiered to be "identifiers"
they must be in [a-zA-Z0-9_-]. Option names are the same except they
do not allow '-' as they need to be made available through the env vars
and '-' is not supported there.

Fixes #1946
 2018-03-25 16:35:33 +11:00
Maxime Coste
db7b43acd5 Restore client name after converting to client 
When Kakoune forked the sever to background, the newly converted
to client process (the original client/server process) was not
preserving its previous client name.
 2018-03-23 07:36:18 +11:00
Maxime Coste
d8dc7d7f39 Go back to getpwuid call to get user name from user id 
Unfortunately, reading /etc/passwd is not enough.
 2017-12-15 08:19:56 +11:00
Maxime Coste
a33d18e125 Go back to getpwuid call on OSX 
Reading /etc/passwd on OSX does not give us the full list of users.

Fixes #1758
 2017-12-09 12:13:02 +08:00
Maxime Coste
274367116a Replace uses of getpwuid which is incompatible with static linking 
Introduce a get_user_name function which parses '/etc/passwd' to find
the username associated with a user id.
 2017-12-04 15:19:57 +08:00
Maxime Coste
2b6c84fc40 Add missing include in remote.cc 
strerror is defined in <string.h>
 2017-11-06 12:45:14 +08:00
Maxime Coste
0a081b9f31 Do not allow rename-session to introduce '/' in session names 2017-11-06 11:55:56 +08:00
Maxime Coste
aa82a90c39 Remote: stricter validation of the session names 
Creating a session will not accept any slashes in the session path,
connecting to an existing session will accept at most one slash to
allow for specifying the session of a different user.

Fixes #1635
 2017-11-04 12:01:25 +08:00
Maxime Coste
bd66aff808 Tolerate unwritable socket when trying to send the disconnection message 
Fixes #1552
 2017-09-07 19:37:58 +08:00
Maxime Coste
e80b36b495 Expose client pid as $kak_client_pid 
As requested in #1414
 2017-08-28 13:12:45 +07:00
Maxime Coste
f7bed9eb18 Support specifying an exit status on quit commands 
The current client exit status can be specified as an optional
parameter, is nothing is given the exit status will be 0.

Fixes #1230
 2017-08-23 13:33:13 +07:00
Maxime Coste
4e7a357a47 Fix various undefined behaviours detected by UBSan 2017-06-26 11:27:18 +01:00
Maxime Coste
91bfd714e4 Place hardware terminal cursor at the current main cursor/prompt cursor position 
Fixes #1318
Also fixes https://gitlab.com/gnachman/iterm2/issues/5408
 2017-04-12 10:39:17 +01:00
Maxime Coste
e44f95820e Fixes some clang-tidy warning and add a few missing meta.hh include 2017-03-16 23:34:02 +00:00
Maxime Coste
f0ae0b8410 Replace IdMap with HashMap 2017-03-07 01:12:37 +00:00
Maxime Coste
e8ee8c23d8 Support the +line syntax for clients as well. 
Fix a crash on daemon quit as well.
 2017-01-21 12:17:49 +00:00
Maxime Coste
dcd8f6ef01 Apply clang-tidy modernize to the codebase 2017-01-08 22:39:01 +00:00
Maxime Coste
e42881fa38 Fix remaining uses of hardcoded /tmp to get the socket paths 
Fixes #1097
 2017-01-01 13:10:08 +00:00
Maxime Coste
b7a0aa7546 Ensure we return 0 on exit from graceful disconnection 
Fixes #1042
 2016-12-20 10:34:48 +00:00
Maxime Coste
4b696836d1 Fix hardcoded uses of "/tmp" 
Closes #1032
 2016-12-20 04:04:47 +00:00
Maxime Coste
dc84cdd538 Add more diagnostic information when failing to bind/listen to socket 2016-12-17 05:46:04 +00:00
Maxime Coste
28ddb3cb1f Ignore eventual / suffix in TMPDIR 2016-12-17 05:25:43 +00:00
Maxime Coste
831887cd3a Improve general security of the unix sockets 
* Use the stricky bit on the shared kakoune folder
* Do not allow read/write access to user folder
* Respect $TMPDIR when set

Fixes #1007
 2016-12-15 23:47:34 +00:00
Maxime Coste
a65e8142f3 Rework handling of initial coordinates so that init commands can change them 
Fixes #944
 2016-12-01 20:55:20 +00:00
Maxime Coste
8c862c4eea Only write to remote socket when we know they are writable 
Buffer data (in an horribly innefficient way for now), and use the
event manager to watch for the socket being ready for a write.

Fixes #945
 2016-12-01 20:11:09 +00:00
Maxime Coste
95c1528342 Fix crash when a client sends a packet advertising a wrong size 
If the given size is less than the header size, the message is
clearly invalid, disconnect the client in that case.
 2016-12-01 19:45:23 +00:00
Maxime Coste
7defdd3039 Make FDWatcher support Read, Write and Except events, instead of just Read 2016-12-01 19:44:07 +00:00
Maxime Coste
3a81260917 Simplify greatly UI input handling 
This round trip through an input callback expected to call
is_key_available and get_key was overcomplicated, just send the
keys as they arrive, the client is already buffering due to urgent
event mode.
 2016-11-29 21:59:36 +00:00
Maxime Coste
2fd1414b05 Clean up includes of user_interface.hh 2016-11-29 19:53:11 +00:00
Maxime Coste
0dff8a7d3f Small remote code cleanup 2016-11-29 19:52:57 +00:00
Maxime Coste
f904402486 Handle all available keys when a RemoteClient input is available 
We were just treating the next key. Which led to <esc> byte
remaining after suspend, that led that <esc> being interpretted
as <alt> when the following key got available.

Fixes #739
 2016-10-06 23:47:44 +01:00
Maxime Coste
35559b65dd Support codepoints of variable width 
Add a ColumnCount type and use it in place of CharCount whenever
more appropriate, take column size of codepoints into account for
vertical movements and docstring wrapping.

Fixes #811
 2016-10-01 13:45:00 +01:00
Maxime Coste
21a76d135c Fix handling of remote errors in the accepter 2016-09-05 13:47:56 +01:00
Maxime Coste
4fc20b8d7d Rework client quitting and handling of remote errors 
Client quitting no longer immediately unwinds, client is just pushed
for deletion until we get back to the main loop, similarly to what
happens for buffer and window deletion.
 2016-09-04 17:56:07 +01:00
Maxime Coste
563497ade7 Use proper buffering when reading remote messages 
Messages now have their size in a header, along with their type
and are only executed once fully received. We dont block anymore
while trying to read a full message.
 2016-09-04 11:17:35 +01:00
Maxime Coste
044a6ce860 Rework binary network protocol to be more message based 
We cannot just write to Kakoune socket from any application anymore,
use of kak -p is mandatory, as we now have an introduction to write.
 2016-09-04 11:17:34 +01:00
Maxime Coste
8b02bb749d Add a fd_readable(int fd) helper function 
Use it instead of direct calls to select scatered around the code
base.
 2016-08-30 22:56:47 +01:00
Maxime Coste
bedf2f703c Small code cleanups 2016-08-09 21:45:06 +01:00
Maxime Coste
2425f4a781 Tweak session renaming code 2016-07-28 00:16:41 +01:00