xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rc windowing tmux: remove redundant backgrounding

Browse Source 
The tmux-terminal commands typically run

    tmux split-window kak -c ${kak_session} </dev/null >/dev/null 2>&1 &

The tmux process runs in the background with output silenced.  This is
not necessary because "tmux split-window" is a thin client that
merely forwards its arguments to the tmux server. All our wrappers
for other terminal-servers (kitty, iterm, screen, wezterm, zellij)
simply run in the foreground, not silencing any errors.

The tmux backgrounding was added in 208b91627 (Move client.kak as
x11.kak and change tmux.kak to be its peer, 2015-11-17), probably for
consistency with x11.kak. That one is different however because it
potentially spawns a full terminal, not just a client that briefly
talks to a terminal server - that's why x11-terminal needs to use
"setsid," to avoid killing said terminal when we signal our process
group.

Remove the backgrounding from tmux.kak for consistency and to reduce
surprise.
This commit is contained in:
Johannes Altmanninger 2024-03-07 14:49:49 +01:00 committed by Maxime Coste
parent a1c52e08a4
commit f26d4ea4bf
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
rc/windowing/tmux.kak
View File

@ -26,9 +26,9 @@ define-command -hidden -params 2.. tmux-terminal-impl %{
# ideally we should escape single ';' to stop tmux from interpreting it as a new command # ideally we should escape single ';' to stop tmux from interpreting it as a new command
# but that's probably too rare to care # but that's probably too rare to care
if [ -n "$TMPDIR" ]; then if [ -n "$TMPDIR" ]; then
TMUX=$tmux tmux $tmux_args env TMPDIR="$TMPDIR" "$@" < /dev/null > /dev/null 2>&1 & TMUX=$tmux tmux $tmux_args env TMPDIR="$TMPDIR" "$@"
else else
TMUX=$tmux tmux $tmux_args "$@" < /dev/null > /dev/null 2>&1 & TMUX=$tmux tmux $tmux_args "$@"
fi fi
} }
} }