xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix DisplayLine::trim_front quadratic behaviour

Browse Source 
Erasing fully trimmed display atoms one by one means we have to
shift all the remaining ones every time. This is wasteful and we
can just erase all the fully trimmed atom in one go.

Fixes #4797
This commit is contained in:
Maxime Coste 2023-02-03 11:31:13 +11:00
parent 9257beac88
commit eb0e983133
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/display_buffer.cc
View File

@ -252,12 +252,15 @@ bool DisplayLine::trim_from(ColumnCount first_col, ColumnCount front, ColumnCoun
} }
} }
auto front_it = it;
while (front > 0 and it != end()) while (front > 0 and it != end())
{ {
front -= it->trim_begin(front); front -= it->trim_begin(front);
kak_assert(it->empty() or front == 0);
if (it->empty()) if (it->empty())
it = m_atoms.erase(it); ++it;
} }
m_atoms.erase(front_it, it);
it = begin(); it = begin();
for (; it != end() and col_count > 0; ++it) for (; it != end() and col_count > 0; ++it)