xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a limit to the size of selection with which we will try to diff on pipe

Browse Source 
Limit to 100K of data for now, as we diff at the byte level.
This commit is contained in:
Maxime Coste 2018-02-09 21:47:18 +11:00
parent bbf62d1779
commit e46a5697e5
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/normal.cc
View File

@ -470,6 +470,16 @@ void command(Context& context, NormalParams params)
void apply_diff(Buffer& buffer, BufferCoord pos, StringView before, StringView after) void apply_diff(Buffer& buffer, BufferCoord pos, StringView before, StringView after)
{ {
// The diff algorithm is O(ND) with N the sum of string len, and D the diff count
// do not use it if our data is too big
constexpr ByteCount size_limit = 100 * 1024;
if (before.length() + after.length() > size_limit)
{
buffer.erase(pos, buffer.advance(pos, before.length()));
buffer.insert(pos, after);
return;
}
auto diffs = find_diff(before.begin(), (int)before.length(), after.begin(), (int)after.length()); auto diffs = find_diff(before.begin(), (int)before.length(), after.begin(), (int)after.length());
for (auto& diff : diffs) for (auto& diff : diffs)