xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove wrong rejection of upper case mappings in goto mode

Browse Source 
Mapping upper case keys is legitimate, for exampled so that they behave
the same as a lower case mapping. The current rejection of those mappings
is a misguided attempt to prevent mapping *to* upper case keys as those
will never get triggered.

Closes #4769
This commit is contained in:
Maxime Coste 2022-11-04 16:43:55 +11:00
parent ca6a701b80
commit dcdafdea77
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/commands.cc
View File

@ -1875,11 +1875,6 @@ const CommandDesc map_key_cmd = {
if (key.size() != 1) if (key.size() != 1)
throw runtime_error("only a single key can be mapped"); throw runtime_error("only a single key can be mapped");
KeymapMode lower_case_only_modes[] = {KeymapMode::Goto};
if (key[0].codepoint().map(iswupper).value_or(false) and
contains(lower_case_only_modes, keymap_mode))
throw runtime_error("mode only supports lower case mappings");
KeyList mapping = parse_keys(parser[3]); KeyList mapping = parse_keys(parser[3]);
keymaps.map_key(key[0], keymap_mode, std::move(mapping), keymaps.map_key(key[0], keymap_mode, std::move(mapping),
trim_indent(parser.get_switch("docstring").value_or(""))); trim_indent(parser.get_switch("docstring").value_or("")));