xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix performance issue when pasting many selection

Browse Source 
The previous code was advancing from the general insertion point
for all selection, instead of iterating only once from insertion
point until the end of inserted text.
This commit is contained in:
Maxime Coste 2020-11-07 10:14:18 +11:00
parent 94ac3084e1
commit b1745ee8d3
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/normal.cc
View File

@ -748,12 +748,14 @@ void paste_all(Context& context, NormalParams params)
Vector<Selection> result; Vector<Selection> result;
for (auto& ins_pos : insert_pos) for (auto& ins_pos : insert_pos)
{ {
ByteCount pos = 0; ByteCount pos_offset = 0;
BufferCoord pos = ins_pos;
for (auto offset : offsets) for (auto offset : offsets)
{ {
result.emplace_back(buffer.advance(ins_pos, pos), BufferCoord end = buffer.advance(pos, offset - pos_offset - 1);
buffer.advance(ins_pos, offset-1)); result.emplace_back(pos, end);
pos = offset; pos = buffer.next(end);
pos_offset = offset;
} }
} }
if (not result.empty()) if (not result.empty())