From 7b2772ef8988b8b4a24b57638cecf5ff00fe5219 Mon Sep 17 00:00:00 2001 From: Chris Webb Date: Sun, 10 Dec 2023 10:58:42 +0000 Subject: [PATCH] Change use of deprecated '->' operator on an iterator In display_buffer.hh, the '->' operator is used on an iterator, but (surprisingly) this is deprecated from C++20 because of x-value vs l-value ambiguity. Now clang's -Wdeprecated-declarations warns about it as we declare -std=c++2a. See https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1252r2.pdf which was adopted for 2019-03. --- src/display_buffer.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/display_buffer.hh b/src/display_buffer.hh index 0fef5258..c13bd0b9 100644 --- a/src/display_buffer.hh +++ b/src/display_buffer.hh @@ -141,7 +141,7 @@ public: if (auto first = std::find_if(beg, end, has_buffer_range); first != end) { auto& last = *std::find_if(std::reverse_iterator(end), std::reverse_iterator(first), has_buffer_range); - m_range.begin = std::min(m_range.begin, first->begin()); + m_range.begin = std::min(m_range.begin, (*first).begin()); m_range.end = std::max(m_range.end, last.end()); } return m_atoms.insert(pos, beg, end);