xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not tag BufferIterator as random access

Browse Source 
Boost regex considers that random access means fast distance
computation, which is not the case for BufferIterator where
Buffer::distance is O(num lines between them) which can get
big on large files.

Fixes #462
This commit is contained in:
Maxime Coste 2015-11-04 00:58:56 +00:00
parent 6273aa9443
commit 719997f0ab
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/buffer.hh
View File

@ -24,7 +24,7 @@ public:
using difference_type = size_t; using difference_type = size_t;
using pointer = const value_type*; using pointer = const value_type*;
using reference = const value_type&; using reference = const value_type&;
using iterator_category = std::random_access_iterator_tag; using iterator_category = std::bidirectional_iterator_tag;
BufferIterator() : m_buffer(nullptr) {} BufferIterator() : m_buffer(nullptr) {}
BufferIterator(const Buffer& buffer, ByteCoord coord); BufferIterator(const Buffer& buffer, ByteCoord coord);