Fix selecting of insert text in SelectionList::insert

src/selection.cc

@@ -499,8 +499,11 @@ void SelectionList::insert(ArrayView<String> strings, InsertMode mode,
 
         if (select_inserted or mode == InsertMode::Replace)
         {
-            sel.min() = change.begin;
-            sel.max() = m_buffer->char_prev(change.end);
+            // we want min and max from *before* we do any change
+            auto& min = sel.min();
+            auto& max = sel.max();
+            min = change.begin;
+            max = m_buffer->char_prev(change.end);
         }
         else
         {

test/unit/concat-paste-line/cmd

@@ -0,0 +1 @@
+xy<a-p>

test/unit/concat-paste-line/in

@@ -0,0 +1 @@
+line

test/unit/concat-paste-line/out

@@ -0,0 +1,2 @@
+line
+line

test/unit/concat-paste-line/state

@@ -0,0 +1 @@
+2.1+5