xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid unneeded inc/dec rec in RefPtr::operator=

Browse Source
This commit is contained in:
Maxime Coste 2015-11-10 13:50:15 +00:00
parent 95c1d25f28
commit 53184829ee
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/ref_ptr.hh
View File

@ -24,11 +24,15 @@ struct RefPtr
RefPtr& operator=(const RefPtr& other) RefPtr& operator=(const RefPtr& other)
{ {
release(); if (other.m_ptr != m_ptr)
m_ptr = other.m_ptr; {
acquire(); release();
m_ptr = other.m_ptr;
acquire();
}
return *this; return *this;
} }
RefPtr& operator=(RefPtr&& other) RefPtr& operator=(RefPtr&& other)
{ {
release(); release();
@ -40,9 +44,12 @@ struct RefPtr
RefPtr& operator=(T* ptr) RefPtr& operator=(T* ptr)
{ {
release(); if (ptr != m_ptr)
m_ptr = ptr; {
acquire(); release();
m_ptr = ptr;
acquire();
}
return *this; return *this;
} }