Clamp selection generated in selection_list_from_string

Fixes #733

src/selection.cc

@@ -337,6 +337,12 @@ Vector<Selection> compute_modified_ranges(Buffer& buffer, size_t timestamp)
     return ranges;
 }
 
+static void clamp(Selection& sel, const Buffer& buffer)
+{
+    sel.anchor() = buffer.clamp(sel.anchor());
+    sel.cursor() = buffer.clamp(sel.cursor());
+}
+
 void update_selections(Vector<Selection>& selections, size_t& main, Buffer& buffer, size_t timestamp)
 {
     if (timestamp == buffer.timestamp())
@@ -366,10 +372,8 @@ void update_selections(Vector<Selection>& selections, size_t& main, Buffer& buff
                                   compare_selections));
     }
     for (auto& sel : selections)
-    {
+        clamp(sel, buffer);
-        sel.anchor() = buffer.clamp(sel.anchor());
+
-        sel.cursor() = buffer.clamp(sel.cursor());
-    }
     selections.erase(merge_overlapping(selections.begin(), selections.end(),
                                        main, overlaps), selections.end());
 }
@@ -604,7 +608,11 @@ SelectionList selection_list_from_string(Buffer& buffer, StringView desc)
 
     Vector<Selection> sels;
     for (auto sel_desc : desc | split<StringView>(':'))
-        sels.push_back(selection_from_string(sel_desc));
+    {
+        auto sel = selection_from_string(sel_desc);
+        clamp(sel, buffer);
+        sels.push_back(sel);
+    }
     return {buffer, std::move(sels)};
 }
 

test/regression/733-selection-list-from-string-not-valid/cmd

@@ -0,0 +1 @@
+:select 100.100,100.200<ret>

test/regression/733-selection-list-from-string-not-valid/in

@@ -0,0 +1 @@
+foo

test/regression/733-selection-list-from-string-not-valid/out

@@ -0,0 +1 @@
+foo