Ensure that at least one character follows a ',' or a '+' sign in a face

description (respectively a background color and attributes).
This commit is contained in:
Frank LENORMAND 2015-12-11 22:58:28 +03:00
parent 1ed866dbf0
commit 49a5bbf3ca

View File

@ -9,10 +9,15 @@ namespace Kakoune
static Face parse_face(StringView facedesc)
{
const String invalid_face_error = "invalid face description, expected <fg>[,<bg>][+<attr>]";
auto bg_it = find(facedesc, ',');
auto attr_it = find(facedesc, '+');
if (bg_it != facedesc.end() and attr_it < bg_it)
throw runtime_error("invalid face description, expected <fg>[,<bg>][+<attr>]");
if (bg_it != facedesc.end()
and (attr_it < bg_it or (bg_it + 1) == facedesc.end()))
throw runtime_error(invalid_face_error);
if (attr_it != facedesc.end()
and (attr_it + 1) == facedesc.end())
throw runtime_error(invalid_face_error);
Face res;
res.fg = attr_it != facedesc.begin() ?
str_to_color({facedesc.begin(), std::min(attr_it, bg_it)}) : Color::Default;