xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix use after move in HashMap::insert

Browse Source 
Apparently GCC builds worked fine but Clang builds started failing the
"(hash == hash_value(item_key(item)))" assertion.
This commit is contained in:
Johannes Altmanninger 2023-11-18 19:07:23 +01:00
parent 296ab1a1ff
commit 4499b26ca4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/hash_map.hh
View File

@ -214,7 +214,8 @@ struct HashMap
constexpr EffectiveValue& insert(Item item) constexpr EffectiveValue& insert(Item item)
{ {
return insert(std::move(item), hash_value(item_key(item))); const auto hash = hash_value(item_key(item));
return insert(std::move(item), hash);
} }
template<typename KeyType> requires IsHashCompatible<Key, KeyType> template<typename KeyType> requires IsHashCompatible<Key, KeyType>