xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash when iterating through options on window creation

Browse Source 
Window::on_option_changed calls hooks, which can do anything
including adding/removing options in the various option managers

Fixes #1863
This commit is contained in:
Maxime Coste 2018-02-21 22:47:41 +11:00
parent 69a0ad09b4
commit 35d68d2f82
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/window.cc
View File

@ -30,7 +30,10 @@ Window::Window(Buffer& buffer)
setup_builtin_highlighters(m_builtin_highlighters.group()); setup_builtin_highlighters(m_builtin_highlighters.group());
for (auto& option : options().flatten_options()) // gather as on_option_changed can mutate the option managers
for (auto& option : options().flatten_options()
| transform([](auto& ptr) { return ptr.get(); })
| gather<Vector<const Option*>>())
on_option_changed(*option); on_option_changed(*option);
} }