xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix horrible leak in String::Data::operator=(String::Data&&)

Browse Source 
And that, my friends, is why we recommend using standard containers
instead of rolling your own.
This commit is contained in:
Maxime Coste 2016-11-23 01:09:09 +00:00
parent fbd32fb512
commit 1ccccbce04
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/string.cc
View File

@ -34,7 +34,7 @@ String::Data::Data(Data&& other) noexcept
if (other.is_long()) if (other.is_long())
{ {
l = other.l; l = other.l;
other.s.size = 1; other.set_empty();
} }
else else
s = other.s; s = other.s;
@ -52,6 +52,8 @@ String::Data& String::Data::operator=(const Data& other)
String::Data& String::Data::operator=(Data&& other) noexcept String::Data& String::Data::operator=(Data&& other) noexcept
{ {
release();
if (other.is_long()) if (other.is_long())
{ {
l = other.l; l = other.l;