xenia/kakoune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash when quitting the first client while another client is connected

Browse Source
This commit is contained in:
Maxime Coste 2016-12-01 20:55:28 +00:00
parent a65e8142f3
commit 089ee8ac0a
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/client_manager.cc
View File

@ -71,8 +71,12 @@ void ClientManager::process_pending_inputs() const
while (true) while (true)
{ {
bool had_input = false; bool had_input = false;
for (auto& client : m_clients) // Use index based iteration as a m_clients might get mutated during
had_input = client->process_pending_inputs() or had_input; // client input processing, which would break iterator based iteration.
// (its fine to skip a client if that happens as had_input will be true
// if a client triggers client removal)
for (int i = 0; i < m_clients.size(); ++i)
had_input = m_clients[i]->process_pending_inputs() or had_input;
if (not had_input) if (not had_input)
break; break;