From dcdafdea778cc74545d7daaab8b70a6bf200001b Mon Sep 17 00:00:00 2001 From: Maxime Coste Date: Fri, 4 Nov 2022 16:43:55 +1100 Subject: [PATCH] Remove wrong rejection of upper case mappings in goto mode Mapping upper case keys is legitimate, for exampled so that they behave the same as a lower case mapping. The current rejection of those mappings is a misguided attempt to prevent mapping *to* upper case keys as those will never get triggered. Closes #4769 --- src/commands.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/commands.cc b/src/commands.cc index 660a2726..001ba0f9 100644 --- a/src/commands.cc +++ b/src/commands.cc @@ -1875,11 +1875,6 @@ const CommandDesc map_key_cmd = { if (key.size() != 1) throw runtime_error("only a single key can be mapped"); - KeymapMode lower_case_only_modes[] = {KeymapMode::Goto}; - if (key[0].codepoint().map(iswupper).value_or(false) and - contains(lower_case_only_modes, keymap_mode)) - throw runtime_error("mode only supports lower case mappings"); - KeyList mapping = parse_keys(parser[3]); keymaps.map_key(key[0], keymap_mode, std::move(mapping), trim_indent(parser.get_switch("docstring").value_or("")));