xenia/home
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix incorrect reading logic and EAGAIN handling

Browse Source 
This is one of the issues raised by #4410
This commit is contained in:
Maxime Coste 2021-10-29 22:34:16 +11:00
parent be4659097c
commit d2e2caaae6
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/shell_manager.cc
View File

@ -176,9 +176,12 @@ FDWatcher make_reader(int fd, String& contents, OnClose&& on_close)
char buffer[1024]; char buffer[1024];
while (fd_readable(fd)) while (fd_readable(fd))
{ {
size_t size = ::read(fd, buffer, sizeof(buffer)); ssize_t size = ::read(fd, buffer, sizeof(buffer));
if (size <= 0) if (size <= 0)
{ {
if (size < 0 and errno == EAGAIN)
continue; // try again
watcher.disable(); watcher.disable();
on_close(); on_close();
return; return;