xenia/home
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src: Fix undefined behaviour

Browse Source 
Cppcheck produces the following warnings:

```
shared_string.hh:27:49: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour
shared_string.hh:27:49: error: Signed integer overflow for expression '1<<31'.
```

Fixes #4340
This commit is contained in:
Frank LENORMAND 2021-09-10 16:34:38 +03:00
parent 367879ddcf
commit c57a86ce62
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/shared_string.hh
View File

@ -24,7 +24,7 @@ struct StringData : UseMemoryDomain<MemoryDomain::SharedString>
private: private:
StringData(int len) : refcount(0), length(len) {} StringData(int len) : refcount(0), length(len) {}
static constexpr uint32_t interned_flag = 1 << 31; static constexpr uint32_t interned_flag = 1u << 31;
static constexpr uint32_t refcount_mask = ~interned_flag; static constexpr uint32_t refcount_mask = ~interned_flag;
struct PtrPolicy struct PtrPolicy