From ad546e516af06eb5cc624af13abb8bd2fac499f5 Mon Sep 17 00:00:00 2001 From: Maxime Coste Date: Tue, 19 Sep 2017 11:57:02 +0900 Subject: [PATCH] Regex: Small comment tweaks --- src/regex_impl.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/regex_impl.cc b/src/regex_impl.cc index caeec8b5..db180a15 100644 --- a/src/regex_impl.cc +++ b/src/regex_impl.cc @@ -89,6 +89,8 @@ AstNodePtr make_ast_node(Op op, char value = 0, return AstNodePtr{new AstNode{op, value, quantifier, {}}}; } +// Recursive descent parser based on naming using in the ECMAScript +// standard, although the syntax is not fully compatible. template struct Parser { @@ -147,7 +149,7 @@ private: case '\'': pos += 2; return make_ast_node(Op::SubjectEnd); } break; - /* TODO: \`, \', look ahead, look behind */ + /* TODO: look ahead, look behind */ } return nullptr; } @@ -559,8 +561,8 @@ auto test_regex = UnitTest{[]{ auto program = RegexCompiler::compile(re.begin(), re.end()); RegexProgram::dump(program); Exec exec{program}; - kak_assert(exec.match(program, "tchou foo baz")); - kak_assert(not exec.match(program, "tchoufoobaz")); + kak_assert(exec.match(program, "qux foo baz")); + kak_assert(not exec.match(program, "quxfoobaz")); kak_assert(exec.match(program, "bar")); kak_assert(not exec.match(program, "foobar")); }