From e612f26ec161f1f7d4ea640237c2825296af62f7 Mon Sep 17 00:00:00 2001
From: Johannes Altmanninger <aclopte@gmail.com>
Date: Sat, 18 Jul 2020 23:18:07 +0200
Subject: [PATCH] rc: conservative comment highlighting for shells

Fixes spurious comment highlighting for these examples:

	echo \# foo
	echo 1#foo
	echo 2\ #foo
---
 rc/filetype/fish.kak     | 2 +-
 rc/filetype/makefile.kak | 2 +-
 rc/filetype/sh.kak       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/rc/filetype/fish.kak b/rc/filetype/fish.kak
index b027f1b1..6a66ed31 100644
--- a/rc/filetype/fish.kak
+++ b/rc/filetype/fish.kak
@@ -35,7 +35,7 @@ add-highlighter shared/fish regions
 add-highlighter shared/fish/code default-region group
 add-highlighter shared/fish/double_string region (?<!\\)(?:\\\\)*\K" (?<!\\)(\\\\)*"  group
 add-highlighter shared/fish/single_string region (?<!\\)(?:\\\\)*\K' (?<!\\)(\\\\)*'  fill string
-add-highlighter shared/fish/comment       region '#' '$'              fill comment
+add-highlighter shared/fish/comment       region (?<!\\)(?:\\\\)*(?:^|\h)\K# '$' fill comment
 
 add-highlighter shared/fish/double_string/ fill string
 add-highlighter shared/fish/double_string/ regex (\$\w+)|(\{\$\w+\}) 0:variable
diff --git a/rc/filetype/makefile.kak b/rc/filetype/makefile.kak
index 2f7fac00..690461e9 100644
--- a/rc/filetype/makefile.kak
+++ b/rc/filetype/makefile.kak
@@ -30,7 +30,7 @@ provide-module makefile %{
 add-highlighter shared/makefile regions
 
 add-highlighter shared/makefile/content default-region group
-add-highlighter shared/makefile/comment region '#' '$' fill comment
+add-highlighter shared/makefile/comment region (?<!\\)(?:\\\\)*(?:^|\h)\K# '$' fill comment
 add-highlighter shared/makefile/evaluate-commands region -recurse '\(' '\$\(' '\)' fill value
 
 add-highlighter shared/makefile/content/ regex ^\S.*?(::|:|!)\s 0:variable
diff --git a/rc/filetype/sh.kak b/rc/filetype/sh.kak
index 35076d9c..15d139dd 100644
--- a/rc/filetype/sh.kak
+++ b/rc/filetype/sh.kak
@@ -23,7 +23,7 @@ add-highlighter shared/sh/code default-region group
 add-highlighter shared/sh/double_string region  %{(?<!\\)(?:\\\\)*\K"} %{(?<!\\)(?:\\\\)*"} group
 add-highlighter shared/sh/single_string region %{(?<!\\)(?:\\\\)*\K'} %{'} fill string
 add-highlighter shared/sh/expansion region '\$\{' '\}|\n' fill value
-add-highlighter shared/sh/comment region '(?<!\$)(?<!\$\{)#' '$' fill comment
+add-highlighter shared/sh/comment region (?<!\\)(?:\\\\)*(?:^|\h)\K# '$' fill comment
 add-highlighter shared/sh/heredoc region -match-capture '<<-?\h*''?(\w+)''?' '^\t*(\w+)$' fill string
 
 add-highlighter shared/sh/double_string/fill fill string