Small code tweaks regarding flags handling

src/buffer.cc

@@ -7,6 +7,7 @@
 #include "context.hh"
 #include "diff.hh"
 #include "file.hh"
+#include "flags.hh"
 #include "shared_string.hh"
 #include "unit_tests.hh"
 #include "utils.hh"

src/buffer.hh

@@ -3,7 +3,6 @@
 
 #include "clock.hh"
 #include "coord.hh"
-#include "flags.hh"
 #include "safe_ptr.hh"
 #include "scope.hh"
 #include "shared_string.hh"

src/command_manager.cc

@@ -3,6 +3,7 @@
 #include "alias_registry.hh"
 #include "assert.hh"
 #include "context.hh"
+#include "flags.hh"
 #include "register_manager.hh"
 #include "shell_manager.hh"
 #include "utils.hh"

src/command_manager.hh

@@ -3,7 +3,6 @@
 
 #include "coord.hh"
 #include "completion.hh"
-#include "flags.hh"
 #include "array_view.hh"
 #include "shell_manager.hh"
 #include "parameters_parser.hh"
@@ -36,7 +35,6 @@ enum class CommandFlags
     None   = 0,
     Hidden = 1,
 };
-
 constexpr bool with_bit_ops(Meta::Type<CommandFlags>) { return true; }
 
 struct CommandInfo { String name, info; };

src/completion.hh

@@ -4,7 +4,6 @@
 #include <functional>
 #include <algorithm>
 
-#include "flags.hh"
 #include "units.hh"
 #include "string.hh"
 #include "vector.hh"

src/context.hh

@@ -3,7 +3,6 @@
 
 #include "selection.hh"
 #include "optional.hh"
-#include "flags.hh"
 
 namespace Kakoune
 {
@@ -86,6 +85,7 @@ public:
         None = 0,
         Transient = 1,
     };
+    friend constexpr bool with_bit_ops(Meta::Type<Flags>) { return true; }
 
     Context(InputHandler& input_handler, SelectionList selections,
             Flags flags, String name = "");
@@ -183,8 +183,6 @@ private:
     NestedBool m_history_disabled;
 };
 
-constexpr bool with_bit_ops(Meta::Type<Context::Flags>) { return true; }
-
 struct ScopedEdition
 {
     ScopedEdition(Context& context)

src/file.cc

@@ -3,6 +3,7 @@
 #include "assert.hh"
 #include "buffer.hh"
 #include "exception.hh"
+#include "flags.hh"
 #include "ranked_match.hh"
 #include "regex.hh"
 #include "string.hh"

src/file.hh

@@ -2,7 +2,7 @@
 #define file_hh_INCLUDED
 
 #include "array_view.hh"
-#include "flags.hh"
+#include "meta.hh"
 #include "units.hh"
 #include "vector.hh"
 
@@ -78,7 +78,6 @@ enum class FilenameFlags
     OnlyDirectories = 1 << 0,
     Expand = 1 << 1
 };
-
 constexpr bool with_bit_ops(Meta::Type<FilenameFlags>) { return true; }
 
 CandidateList complete_filename(StringView prefix, const Regex& ignore_regex,

src/parameters_parser.cc

@@ -1,5 +1,7 @@
 #include "parameters_parser.hh"
 
+#include "flags.hh"
+
 namespace Kakoune
 {
 

src/parameters_parser.hh

@@ -3,8 +3,8 @@
 
 #include "exception.hh"
 #include "hash_map.hh"
+#include "meta.hh"
 #include "array_view.hh"
-#include "flags.hh"
 #include "optional.hh"
 #include "string.hh"
 

src/selectors.cc

@@ -1,6 +1,7 @@
 #include "selectors.hh"
 
 #include "buffer_utils.hh"
+#include "flags.hh"
 #include "optional.hh"
 #include "regex.hh"
 #include "string.hh"

src/selectors.hh

@@ -1,7 +1,6 @@
 #ifndef selectors_hh_INCLUDED
 #define selectors_hh_INCLUDED
 
-#include "flags.hh"
 #include "selection.hh"
 
 namespace Kakoune