From 73c446e3790f9e8c95a1c4e18d3a739644dcfe70 Mon Sep 17 00:00:00 2001
From: Maxime Coste <frrrwww@gmail.com>
Date: Thu, 22 Nov 2012 14:28:14 +0100
Subject: [PATCH] code style cleanup in CommandManager

---
 src/command_manager.cc | 10 +++++-----
 src/command_manager.hh | 27 ++++++++++++---------------
 2 files changed, 17 insertions(+), 20 deletions(-)

diff --git a/src/command_manager.cc b/src/command_manager.cc
index 6a130ec7..470bd7cc 100644
--- a/src/command_manager.cc
+++ b/src/command_manager.cc
@@ -16,19 +16,19 @@ bool CommandManager::command_defined(const String& command_name) const
     return m_commands.find(command_name) != m_commands.end();
 }
 
-void CommandManager::register_command(const String& command_name,
+void CommandManager::register_command(String command_name,
                                       Command command,
-                                      const CommandCompleter& completer)
+                                      CommandCompleter completer)
 {
-    m_commands[command_name] = CommandDescriptor { command, completer };
+    m_commands[command_name] = { std::move(command), std::move(completer) };
 }
 
 void CommandManager::register_commands(const memoryview<String>& command_names,
                                        Command command,
-                                       const CommandCompleter& completer)
+                                       CommandCompleter completer)
 {
     for (auto command_name : command_names)
-        register_command(command_name, command, completer);
+        m_commands[command_name] = { command, completer };
 }
 
 parse_error::parse_error(const String& error)
diff --git a/src/command_manager.hh b/src/command_manager.hh
index 07e7882b..f166f739 100644
--- a/src/command_manager.hh
+++ b/src/command_manager.hh
@@ -14,28 +14,25 @@
 namespace Kakoune
 {
 
-struct Context;
-
 struct parse_error : runtime_error
 {
     parse_error(const String& error);
 };
 
+struct Context;
 using CommandParameters = memoryview<String>;
-
-typedef std::function<void (const CommandParameters&,
-                            Context& context)> Command;
-
-typedef std::function<CandidateList (const Context& context,
-                                     const CommandParameters&,
-                                     size_t, ByteCount)> CommandCompleter;
+using Command = std::function<void (const CommandParameters&,
+                                    Context& context)>;
+using CommandCompleter = std::function<CandidateList (const Context& context,
+                                                      const CommandParameters&,
+                                                      size_t, ByteCount)>;
 
 class PerArgumentCommandCompleter
 {
 public:
-    typedef std::function<CandidateList (const Context&,
-                                         const String&, ByteCount)> ArgumentCompleter;
-    typedef memoryview<ArgumentCompleter> ArgumentCompleterList;
+    using ArgumentCompleter = std::function<CandidateList (const Context&,
+                                            const String&, ByteCount)>;
+    using ArgumentCompleterList = memoryview<ArgumentCompleter>;
 
     PerArgumentCommandCompleter(const ArgumentCompleterList& completers)
         : m_completers(completers.begin(), completers.end()) {}
@@ -61,13 +58,13 @@ public:
 
     bool command_defined(const String& command_name) const;
 
-    void register_command(const String& command_name,
+    void register_command(String command_name,
                           Command command,
-                          const CommandCompleter& completer = CommandCompleter());
+                          CommandCompleter completer = CommandCompleter());
 
     void register_commands(const memoryview<String>& command_names,
                            Command command,
-                           const CommandCompleter& completer = CommandCompleter());
+                           CommandCompleter completer = CommandCompleter());
 
 private:
     void execute_single_command(const CommandParameters& params,