diff --git a/src/buffer.cc b/src/buffer.cc index d384f3bb..266d4905 100644 --- a/src/buffer.cc +++ b/src/buffer.cc @@ -272,7 +272,7 @@ void Buffer::do_insert(const BufferIterator& pos, const String& content) if (start != content.length()) m_lines.push_back({ offset + start, content.substr(start) }); - begin_it = pos; + begin_it = BufferIterator{*this, { pos.line() + 1, 0 }}; end_it = end(); } else @@ -349,8 +349,14 @@ void Buffer::do_erase(const BufferIterator& begin, const BufferIterator& end) void Buffer::apply_modification(const Modification& modification) { const String& content = modification.content; - const BufferIterator& pos = modification.position; + BufferIterator pos = modification.position; + // this may happen when a modification applied at the + // end of the buffer has been inverted for an undo. + if (pos.column() == m_lines[pos.line()].length()) + pos = { pos.buffer(), { pos.line() + 1, 0 }}; + + assert(pos.is_valid()); switch (modification.type) { case Modification::Insert: diff --git a/src/unit_tests.cc b/src/unit_tests.cc index 0793eedc..5e91de03 100644 --- a/src/unit_tests.cc +++ b/src/unit_tests.cc @@ -38,6 +38,15 @@ void test_buffer() begin = buffer.end() - 1; buffer.insert(buffer.end(), "kanaky\n"); assert(buffer.string(begin+1, buffer.end()) == "kanaky\n"); + + buffer.end_undo_group(); + + buffer.begin_undo_group(); + buffer.erase(begin+1, buffer.end()); + buffer.insert(buffer.end(), "mutch\n"); + buffer.end_undo_group(); + buffer.undo(); + assert(buffer.string(buffer.end() - 7, buffer.end()) == "kanaky\n"); } void test_editor()