From 39be51b55c9bb1d8f2c0d9370aacfc6d2250d145 Mon Sep 17 00:00:00 2001 From: Maxime Coste Date: Sat, 5 Aug 2023 10:58:15 +1000 Subject: [PATCH] Fix regression/0-mouse-during-insert test flakyness Do not rely on timing but wait for Kakoune to redraw which is what we actually need: Mouse clicks rely on the current display buffer to resolve the buffer location, so we need to wait for a redraw to happen with `ui_out` --- test/regression/0-mouse-during-insert/script | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/test/regression/0-mouse-during-insert/script b/test/regression/0-mouse-during-insert/script index 94a40c9b..0c972db5 100644 --- a/test/regression/0-mouse-during-insert/script +++ b/test/regression/0-mouse-during-insert/script @@ -1,15 +1,10 @@ ui_out -ignore 4 ui_in '{ "jsonrpc": "2.0", "method": "keys", "params": [ "i" ] }' ui_in '{ "jsonrpc": "2.0", "method": "keys", "params": [ "a" ] }' -sleep .1 +ui_out -ignore 4 ui_in '{ "jsonrpc": "2.0", "method": "mouse_press", "params": [ "left", 0, 2 ] }' -sleep .1 ui_in '{ "jsonrpc": "2.0", "method": "keys", "params": [ "b" ] }' -sleep .1 +ui_out -ignore 4 ui_in '{ "jsonrpc": "2.0", "method": "mouse_release", "params": [ "left", 0, 4 ] }' -sleep .1 ui_in '{ "jsonrpc": "2.0", "method": "keys", "params": [ "c" ] }' -sleep .1 -if [ -n "$CI" ]; then - sleep 1 -fi +ui_out -ignore 1