xenia/home
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Buffer::advance out of bounds access.

Browse Source 
This commit fixes a bug in Buffer::advance where it would first access
m_lines[-1], and then check whether or not that access would have
segfaulted.  This commit moves the check to before the segfault would
occur.
This commit is contained in:
potatoalienof13 2022-12-22 17:34:42 -05:00
parent 86bd4efd25
commit 293d46837d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/buffer.cc
View File

@ -575,9 +575,9 @@ BufferCoord Buffer::advance(BufferCoord coord, ByteCount count) const
count += coord.column; count += coord.column;
while (count < 0) while (count < 0)
{ {
count += m_lines[--line].length(); if (--line < 0)
if (line < 0)
return {0, 0}; return {0, 0};
count += m_lines[line].length();
} }
return { line, count }; return { line, count };
} }