Slight code cleanup in prompt history handling

This commit is contained in:
Maxime Coste 2019-07-21 12:20:47 +10:00
parent b83c09509e
commit 1a16590960

View File

@ -789,8 +789,7 @@ public:
completion); completion);
} }
if (not context().history_disabled()) history_push(line);
history_push(line);
context().print_status(DisplayLine{}); context().print_status(DisplayLine{});
if (context().has_client()) if (context().has_client())
context().client().menu_hide(); context().client().menu_hide();
@ -806,8 +805,7 @@ public:
} }
else if (key == Key::Escape or key == ctrl('c')) else if (key == Key::Escape or key == ctrl('c'))
{ {
if (not context().history_disabled()) history_push(line);
history_push(line);
context().print_status(DisplayLine{}); context().print_status(DisplayLine{});
if (context().has_client()) if (context().has_client())
context().client().menu_hide(); context().client().menu_hide();
@ -1103,7 +1101,7 @@ private:
void history_push(StringView entry) void history_push(StringView entry)
{ {
if (entry.empty() or if (entry.empty() or context().history_disabled() or
(m_flags & PromptFlags::DropHistoryEntriesWithBlankPrefix and (m_flags & PromptFlags::DropHistoryEntriesWithBlankPrefix and
is_horizontal_blank(entry[0_byte]))) is_horizontal_blank(entry[0_byte])))
return; return;