xenia/home
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix clang warning regarding useless braces when using HashSet

Browse Source 
clang/clangd complain about the new HashSet type:

	hash_map.cc:98:20: warning: braces around scalar initializer [-Wbraced-scalar-init]
	        set.insert({10});
	                   ^~~~

The argument to HashSet<int>::insert is just an int, so we don't
need braces.  Only an actual HashMap would need braces to construct
a HashItem object.
This commit is contained in:
Johannes Altmanninger 2022-08-28 15:16:00 +02:00
parent 021da117cf
commit 1333fe21d0
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/hash_map.cc
View File

@ -95,8 +95,8 @@ UnitTest test_hash_set{[] {
// Basic usage // Basic usage
{ {
HashSet<int> set; HashSet<int> set;
set.insert({10}); set.insert(10);
set.insert({20}); set.insert(20);
kak_assert(set.find_index(0) == -1); kak_assert(set.find_index(0) == -1);
kak_assert(set.find_index(10) == 0); kak_assert(set.find_index(10) == 0);
kak_assert(set.find_index(20) == 1); kak_assert(set.find_index(20) == 1);
@ -113,8 +113,8 @@ UnitTest test_hash_set{[] {
// Replace Multiple entries with the same key // Replace Multiple entries with the same key
{ {
HashSet<int> set; HashSet<int> set;
set.insert({10}); set.insert(10);
set.insert({10}); set.insert(10);
kak_assert(set.find_index(10) == 0); kak_assert(set.find_index(10) == 0);
kak_assert(set.size() == 1); kak_assert(set.size() == 1);
set.remove(10); set.remove(10);
@ -124,15 +124,15 @@ UnitTest test_hash_set{[] {
// Multiple entries with the same key // Multiple entries with the same key
{ {
MultiHashSet<int> set; MultiHashSet<int> set;
set.insert({10}); set.insert(10);
set.insert({10}); set.insert(10);
kak_assert(set.find_index(10) == 0); kak_assert(set.find_index(10) == 0);
set.remove(10); set.remove(10);
kak_assert(set.find_index(10) == 0); kak_assert(set.find_index(10) == 0);
set.remove(10); set.remove(10);
kak_assert(set.find_index(10) == -1); kak_assert(set.find_index(10) == -1);
set.insert({20}); set.insert(20);
set.insert({20}); set.insert(20);
set.remove_all(20); set.remove_all(20);
kak_assert(set.find_index(20) == -1); kak_assert(set.find_index(20) == -1);
} }
@ -140,7 +140,7 @@ UnitTest test_hash_set{[] {
// Check hash compatible support // Check hash compatible support
{ {
HashSet<String> set; HashSet<String> set;
set.insert({"test"}); set.insert("test");
kak_assert(set["test"_sv] == "test"); kak_assert(set["test"_sv] == "test");
set.remove("test"_sv); set.remove("test"_sv);
} }