xenia/home
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Only trigger PromptEvent::Change on idle

Browse Source 
There is no need to trigger that event on every keystroke, we can
trigger it only when we hit the idle timeout, avoiding computations
when input keys are pasted.
This commit is contained in:
Maxime Coste 2017-06-07 20:16:19 +01:00
parent b81500c0e4
commit 03f8679e5c
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/input_handler.cc
View File

@ -698,6 +698,11 @@ public:
[this](Timer& timer) { [this](Timer& timer) {
if (m_autoshowcompl and m_refresh_completion_pending) if (m_autoshowcompl and m_refresh_completion_pending)
refresh_completions(CompletionFlags::Fast); refresh_completions(CompletionFlags::Fast);
if (m_line_changed)
{
m_callback(m_line_editor.line(), PromptEvent::Change, context());
m_line_changed = false;
}
context().hooks().run_hook("PromptIdle", "", context()); context().hooks().run_hook("PromptIdle", "", context());
}} }}
{ {
@ -752,7 +757,7 @@ public:
m_line_editor.insert(reg); m_line_editor.insert(reg);
display(); display();
m_callback(m_line_editor.line(), PromptEvent::Change, context()); m_line_changed = true;
} }
}, "Enter register name", register_doc); }, "Enter register name", register_doc);
display(); display();
@ -766,7 +771,7 @@ public:
{ {
m_line_editor.insert(*cp); m_line_editor.insert(*cp);
display(); display();
m_callback(m_line_editor.line(), PromptEvent::Change, context()); m_line_changed = true;
} }
}, "raw insert", "enter key to insert"); }, "raw insert", "enter key to insert");
display(); display();
@ -867,7 +872,7 @@ public:
} }
display(); display();
m_callback(line, PromptEvent::Change, context()); m_line_changed = true;
if (enabled()) // The callback might have disabled us if (enabled()) // The callback might have disabled us
m_idle_timer.set_next_date(Clock::now() + get_idle_timeout(context())); m_idle_timer.set_next_date(Clock::now() + get_idle_timeout(context()));
} }
@ -950,6 +955,7 @@ private:
void on_enabled() override void on_enabled() override
{ {
display(); display();
m_line_changed = false;
m_callback(m_line_editor.line(), PromptEvent::Change, context()); m_callback(m_line_editor.line(), PromptEvent::Change, context());
m_idle_timer.set_next_date(Clock::now() + get_idle_timeout(context())); m_idle_timer.set_next_date(Clock::now() + get_idle_timeout(context()));
} }
@ -971,6 +977,7 @@ private:
bool m_prefix_in_completions = false; bool m_prefix_in_completions = false;
String m_prefix; String m_prefix;
LineEditor m_line_editor; LineEditor m_line_editor;
bool m_line_changed = false;
PromptFlags m_flags; PromptFlags m_flags;
bool m_autoshowcompl; bool m_autoshowcompl;
bool m_refresh_completion_pending = true; bool m_refresh_completion_pending = true;